-
Notifications
You must be signed in to change notification settings - Fork 9
Create main.yml #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create main.yml #334
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,23 @@ | ||||||
| name: Auto-label UX issues | ||||||
|
|
||||||
| on: | ||||||
| issues: | ||||||
| types: [opened, assigned, edited] | ||||||
|
|
||||||
| jobs: | ||||||
| add-ux-label: | ||||||
| runs-on: ubuntu-latest | ||||||
| if: > | ||||||
| github.event.issue.assignees && | ||||||
| ( | ||||||
| contains(toJson(github.event.issue.assignees), 'traviskroeker') || | ||||||
| contains(toJson(github.event.issue.assignees), 'thao-do') || | ||||||
| contains(toJson(github.event.issue.assignees), 'lynwilhelm') | ||||||
|
Comment on lines
+13
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm... I wonder if there should be a document somewhere where we record all the places that might need to be updated if a new UX member gets added. @lynwilhelm do you plan to add this to other repos too?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My workflow usually is to put a UX label on it first, before ever assigning it to anyone. This seems like it's the reverse of that. Should we have an action that detects the ux label, and then adds the ticket to a project somewhere? Or maybe auto-assigns someone? As part of our github reorg, there will be a ux github team (https://github.com/orgs/AllenCell/teams/ux-team). |
||||||
| ) | ||||||
|
|
||||||
| steps: | ||||||
| - name: Add UX label | ||||||
| uses: actions-ecosystem/action-add-labels@v1 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
It's safer to pin a specific commit for security reasons! It looks like this repo had some tags get rearranged behavior recently (actions-ecosystem/action-add-labels#485) so better to be safe than sorry. |
||||||
| with: | ||||||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||
| labels: ux | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this file? "main.yml" isn't super descriptive, maybe "ux-label.yml" instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely rename. this isn't the main workflow of this repo