Skip to content

Create main.yml#334

Open
lynwilhelm wants to merge 1 commit into
mainfrom
lynwilhelm-patch-2
Open

Create main.yml#334
lynwilhelm wants to merge 1 commit into
mainfrom
lynwilhelm-patch-2

Conversation

@lynwilhelm
Copy link
Copy Markdown
Contributor

Trying to create an action for when an issue is assigned to a UXer, it auto adds a UX label. Long, confusing story about why but this will solve a problem for me.

I have no idea what I'm doing here but hoping this works!

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

Trying to create an action for when an issue is assigned to a UXer, it auto adds a UX label. Long, confusing story about why but this will solve a problem for me.
@lynwilhelm lynwilhelm requested a review from a team as a code owner February 24, 2026 20:47
@lynwilhelm lynwilhelm requested review from ShrimpCryptid and toloudis and removed request for a team February 24, 2026 20:47

steps:
- name: Add UX label
uses: actions-ecosystem/action-add-labels@v1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions-ecosystem/action-add-labels@v1
uses: actions-ecosystem/action-add-labels@bd52874380e3909a1ac983768df6976535ece7f8 #v1.1.0

It's safer to pin a specific commit for security reasons! It looks like this repo had some tags get rearranged behavior recently (actions-ecosystem/action-add-labels#485) so better to be safe than sorry.

Copy link
Copy Markdown
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this file? "main.yml" isn't super descriptive, maybe "ux-label.yml" instead?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely rename. this isn't the main workflow of this repo

Comment on lines +13 to +15
contains(toJson(github.event.issue.assignees), 'traviskroeker') ||
contains(toJson(github.event.issue.assignees), 'thao-do') ||
contains(toJson(github.event.issue.assignees), 'lynwilhelm')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I wonder if there should be a document somewhere where we record all the places that might need to be updated if a new UX member gets added.

@lynwilhelm do you plan to add this to other repos too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My workflow usually is to put a UX label on it first, before ever assigning it to anyone. This seems like it's the reverse of that. Should we have an action that detects the ux label, and then adds the ticket to a project somewhere? Or maybe auto-assigns someone? As part of our github reorg, there will be a ux github team (https://github.com/orgs/AllenCell/teams/ux-team).

@ShrimpCryptid ShrimpCryptid self-requested a review February 25, 2026 18:14
Copy link
Copy Markdown
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as commented, feel free to re-request me

Copy link
Copy Markdown
Contributor

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants