Move nodes and templates to AliceVision's repository #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These templates are moved to AliceVision's repository.
The `Publish` node will remain the only default node that comes with Meshroom.
The nodes contained in these folders, except for the `Publish` node, are all moved to AliceVision's repository.
…lder Since the "pipelines" folder does not exist anymore in Meshroom, there is no use to try and look for any file in it. Instead, we now only look for the paths that have been provided with the `MESHROOM_PIPELINE_TEMPLATES_PATH` environment variable.
`test_multiviewPipeline` relied on the photogrammetry template and its nodes, which are not a part of Meshroom anymore. The test is rewritten to check the same items (serialization, graph equality, etc.) but using dedicated test nodes (which already existed) and template, which is added with this commit. The path of the template is added to `MESHROOM_PIPELINE_TEMPLATES_PATH` when loading the test module.
This test checked that every node in all the available templates was free of any compatibility issue. As templates are not provided with Meshroom, it is not needed anymore.
…idation For now, it contains methods allowing to check whether a template provided as an argument is valid (i.e. has no compatibility issue). It performs a check that's very similar to what `test_templatesVersions` was doing, but it allows this check to be performed from outside of Meshroom.
cbentejac
force-pushed
the
dev/addAVNodes
branch
from
8df8b85 to
cfa33b6
Compare
The tests in that file were using AliceVision nodes, which are now out of Meshroom's repository.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #2697 +/- ##
===========================================
+ Coverage 73.43% 79.01% +5.58%
===========================================
Files 134 39 -95
Lines 7924 5809 -2115
===========================================
- Hits 5819 4590 -1229
+ Misses 2105 1219 -886 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…imes By performing a `initNodes()` every single time `checkTemplateVersions` was called without ever unregistering the nodes, warnings about nodes being already registered were raised when for example calling `checkAllTemplatesVersions`.
fabiencastan
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to alicevision/AliceVision#1845 and removes all the nodes (besides the
Publishnode) and templates from Meshroom's repositories.The
Publishnode is moved into a "general" node folder.Unit tests that were relying on AliceVision nodes are updated to use test nodes instead. The
test_templatesVersiontest is also removed from the test suite, but in order to keep the mechanism that allows to test whether templates are up-to-date, atest.pyproviding such utility functions is added inmeshroom.core.