-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation load from config and display #18
base: main
Are you sure you want to change the base?
Conversation
…of same file in scene
…d annotations black
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the viewer's annotation capabilities and refines the UI for model selection and scene interaction.
- Enables loading annotations from a source configuration and displays them using a new annotation toolbar.
- Introduces a control toolbar for toggling scene components, updates various UI components, and revises state management in the store.
- Reorganizes files by adding new components (e.g., Toolbar, Dropdown, SourceSelector) and removing obsolete ones.
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/components/ui/tooltip.tsx | Adds an optional "side" prop to configure tooltip placement. |
src/components/ui/toolbar.tsx | Introduces reusable toolbar components for UI controls. |
src/components/ui/dropdown.tsx | Creates a new dropdown component for annotation selection. |
src/components/ui/button.tsx | Adds a new "iconSm" variant to the button component. |
src/components/tab.tsx | Simplifies tab layout by removing an unused DisplayControls import. |
src/components/source-selector.tsx | Implements source selection with redundant state update call. |
src/components/scene-tab.tsx | Updates scene tab to incorporate new source and camera selectors. |
src/components/rotation-controls-selector.tsx | Adds a boolean selector for rotation controls. |
src/components/gltf.tsx | Switches from primitive to Clone for glTF model rendering. |
src/components/control-toolbar.tsx | Provides a new control toolbar for scene reset and toggling views. |
src/components/annotation-tools.tsx | Updates annotation tool behaviors based on a view-only mode. |
src/components/annotation-toolbar.tsx | Creates annotation navigation toolbar with dropdown selection. |
src/components/annotation-tab.tsx | Adjusts layout and text capitalization in the annotation tab. |
src/Store.ts | Renames and adds state properties for rotation controls and source collections. |
src/App.tsx | Revises config usage for single and multiple sources, and updates effect hooks. |
Files not reviewed (1)
- package.json: Language not supported
Co-authored-by: Copilot <[email protected]>
PR builds on #17 and that PR should be reviewed/decided on first.
This PR: