Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box shows dimension length labels with measurement units #19

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

JulieWinchester
Copy link
Collaborator

Builds on existing PRs #17 and #18, those should be reviewed and decided on first.

This PR:

  • Adds <BoundsText> component to display bounding box edge length labels with measurement units (see screenshot)
  • Adds a new attribute to <Viewer>, measurementUnits, for setting the initial measurement unit setting.
  • Styles measurement labels, rounding the corners and adding a small black border.
  • Moves some annotation and object measurement functions relating to screen position and intersects into Utils, since functions were previously duplicated between these two modules.
Screenshot 2025-03-27 at 12 39 31 PM

Copy link

codesandbox bot commented Mar 27, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aleph-r3f ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 5:42pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant