Add ak-entrypoint in light version, and add the minimal tooling for running the test and coverage #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienbeau
force-pushed
the
16.0-light-boosted
branch
from
b2d0f2a to
f7f78c5
Compare
… for running the test and coverage
sebastienbeau
force-pushed
the
16.0-light-boosted
branch
from
f7f78c5 to
2b73928
Compare
hparfr
reviewed
Feb 12, 2025
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I see no benefit for this. It will not work with docker exec for instance. So having to repeat the twice the args in the docker-compose is still needed.
hparfr
reviewed
Feb 12, 2025
| # Install tooling for running test and coverage | ||
| ENV PIPX_HOME=/opt/pipx PIPX_BIN_DIR=/usr/local/bin | ||
| RUN --mount=type=cache,target=/root/.cache\ | ||
| python3 -m pip install pipx &&\ |
There was a problem hiding this comment.
what is the value of using pipx inside the container ?
hparfr
reviewed
Feb 12, 2025
| RUN --mount=type=cache,target=/root/.cache\ | ||
| python3 -m pip install pipx &&\ | ||
| pipx install manifestoo &&\ | ||
| pipx install coverage |
There was a problem hiding this comment.
ak_requirement instead or may be in the project directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hparfr if it's fine for you I will do it for the other version of the image