Refactor pg connection #14
Conversation
sebastienbeau
commented
Feb 11, 2025
•
sebastienbeau
commented
- only pass PG variable (the entrypoint will do the mapping for odoo) : see Add ak-entrypoint in light version, and add the minimal tooling for running the test and coverage odoo-docker#26
- remove deprecated file secrets.docker-compose
- remove PG info from secret as it's not a property of the project (todo discuss about multi-project)
sebastienbeau
force-pushed
the
v2-pg-var-refactor
branch
4 times, most recently
from
1204320 to
5ebab96
Compare
- only pass PG variable (the entrypoint will do the mapping for odoo) - remove deprecated file secrets.docker-compose - remove PG info from secret as it's not a property of the project
It's not recommanded to use '-' in database, and using -- everywhere feel weird so just use it for domain
- always use secret as it's a best practice - unencrypt the secret once a the start of the process
sebastienbeau
force-pushed
the
v2-pg-var-refactor
branch
from
5ebab96 to
e8d33f0
Compare
- Port all improvement done in previous version - allow to run test in parallele of update (using different .env file)
sebastienbeau
force-pushed
the
v2-pg-var-refactor
branch
3 times, most recently
from
8375daf to
5f74366
Compare
sebastienbeau
force-pushed
the
v2-pg-var-refactor
branch
from
5f74366 to
9152609
Compare
| @@ -136,6 +136,7 @@ fetch: | |||
| - git fetch --all | |||
| - git checkout ${NEW_HEAD} | |||
| - sops -d ci.secrets.docker-compose.yml > secrets.docker-compose.yml | |||
| - ./bin/generate_env | |||
There was a problem hiding this comment.
generate_env => generate_ci_env
|
@sebastienbeau for the record for the projects we have, we use to mount the host Postgres socket and do a Unix socket connection. Indeed, in small projects/onsite we use Postgres on the same host and when I tried it was a hassle to guess the host Postgres IP from a container and it could even change after restarts or Docker upgrades. The Unix socket works pretty well, but if Postgres is restarted on the host (like after a security upgrade for instance), then the socket is changed somewhat and the Odoo container should be restarted. I'm not sure if it would be great to use a public DNS for the Postgres host in our case (and hence avoid the changing host IP), but may be... Not sure how it might relate with the changes you are doing but just reporting we tend to use it this way... |
