Skip to content

fix: only match assets for correct platform #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clawdeeo merged 1 commit into from
Apr 22, 2026
Merged

fix: only match assets for correct platform #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,13 +394,16 @@ pub fn find_matching_asset(
}
}

// Prefer archives over bare binaries (but still allow bare binaries)
if name_lower.ends_with(".tar.gz")
|| name_lower.ends_with(".tgz")
|| name_lower.ends_with(".tar.xz")
|| name_lower.ends_with(".zip")
{
score += 5;
// Only consider archives if platform matched
if score >= 10 {
// Prefer archives over bare binaries (but still allow bare binaries)
if name_lower.ends_with(".tar.gz")
|| name_lower.ends_with(".tgz")
|| name_lower.ends_with(".tar.xz")
|| name_lower.ends_with(".zip")
{
score += 5;
}
}

// Avoid checksum-like names
Expand Down
Loading