fix: only match assets for correct platform#19
Merged
Conversation
Asset matching was incorrectly selecting Darwin assets on Linux because the archive format bonus (+5) was applied even when platform didn't match. Now archive bonus only applies if platform matched (score >= 10). This prevents incorrect asset selection like: linux x86_64 selecting aarch64-apple-darwin.tar.gz Fixes platform mismatch bug reported in testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report
Platform detection showed correct platform (linux x86_64) but installed wrong asset (aarch64-apple-darwin).
Root Cause
Archive format bonus (+5 points) was applied regardless of platform match. If no Linux asset existed, any archive (even Darwin) would get +5 and become the "best" match.
Fix
Archive bonus now only applies if platform matched (score >= 10).
Testing
Before:
After:
Fixes platform mismatch bug.