chore: add missing poetry-core constraint (<2.0), tighten python version constraint (<3.12) #288
Conversation
…ion constraint (<3.12)
|
/poetry-lock
|
📝 WalkthroughWalkthroughThis pull request focuses on refining dependency management in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Hey there! I noticed you're refining the dependency constraints. Quick question: What drove the decision to narrow the Python version range specifically to Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
Line range hint
32-90: Consider pinning versions for critical dependencies.I notice we have several dependencies using
"*"(e.g., backoff, requests, python-dateutil). While this provides maximum flexibility, it could lead to unexpected behavior. Would you consider:
- Pinning versions for critical dependencies like
backoffandrequests?- Adding at least major version constraints (e.g.,
^2.0.0) to prevent major version bumps?This would help ensure consistent behavior across environments, wdyt? 🤔
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Check: 'source-pokeapi' (skip=false)
- GitHub Check: Check: 'source-the-guardian-api' (skip=false)
- GitHub Check: Check: 'source-shopify' (skip=false)
- GitHub Check: Check: 'source-hardcoded-records' (skip=false)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (2)
pyproject.toml (2)
2-2: LGTM! The poetry-core constraint looks good.Adding the upper bound constraint
<2.0is a good practice to prevent potential breaking changes from major version upgrades. It's also consistent with the existing constraint on poetry-dynamic-versioning.Would you like me to verify if there are any known compatibility issues with poetry-core versions? Here's a script that can help:
✅ Verification successful
The poetry-core constraint
<2.0looks perfect! 👍I checked PyPI and see that while poetry-core 2.x is out (latest 2.0.1), sticking to 1.x series (latest 1.9.1) is a solid choice for stability. The constraint will help avoid any potential breaking changes from the major version bump. WDYT?
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any known issues with poetry-core versions curl -s https://pypi.org/pypi/poetry-core/json | jq -r '.releases | keys[]' | sort -V | tail -n 5Length of output: 129
32-32: Question about Python version constraint rationale.I notice we're tightening the Python version to
<3.12. The PR mentions Pendulum compatibility with Python 3.21, but I think we should clarify a few things:
- The PR description mentions Python 3.21 - is this a typo? Should it be 3.12?
- Would you like me to verify Python 3.12 compatibility for our key dependencies?
Here's a script to check compatibility:
We previously had the incorrect Python constraint (Pendulum doesn't work on Python 3.21) and we didn't constrain poetry-core to <2.0.
This fixes both issues.
Summary by CodeRabbit