Skip to content

Enable ipywidgets 8.x #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yakutovicha wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable ipywidgets 8.x #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3909b59
Enable ipywidgets 8.x
yakutovicha Nov 10, 2025
3aa5b13
Set some necessary defaults.
yakutovicha Nov 24, 2025
fbc4880
Merge branch 'main' into update/support-ipw-8.x
yakutovicha Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions home/app_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ def __init__(self, app, minimalistic=False):
(self._formatted_version(version), version) for version in versions
],
)

ipw.dlink(
(self.app, "available_versions"),
(self.version_selector.version_to_install, "index"),
transform=lambda versions: 0 if versions else None,
Copy link
Contributor

@danielhollas danielhollas Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little confused here: is 0 an index and therefore the latest version is selected by default? Maybe worth a comment.
(also why was this not necessary before?).

)

ipw.dlink(
(self.app, "installed_version"),
(self.version_selector.installed_version, "value"),
Expand Down
1 change: 1 addition & 0 deletions home/app_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def update_page_selector(self, _=None):
self.page_selector.options = list(
range(1, int(len(self.apps_to_display) / self.items_per_page.value + 2))
)
self.page_selector.value = 1
Copy link
Contributor

@danielhollas danielhollas Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very confused by this. 😅 why 1?


# this parts makes sure that render function will always run one time only:
# if page number changed in the previous step - the render was run automatically already
Expand Down
5 changes: 1 addition & 4 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,15 @@ classifiers =
project_urls =
Bug Tracker = https://github.com/aiidalab/aiidalab-home/issues

# TODO: Remove widgetsnbextension pin
# https://github.com/aiidalab/aiidalab-home/issues/149
[options]
packages = find:
install_requires =
Jinja2>=2.11.3,<4
Markdown>=3.4
aiidalab>=v21.10.2
ipython~=7.0
ipywidgets~=7.6
ipywidgets>=7.8.1,<9
Copy link
Member

@edan-bainglass edan-bainglass Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we still support 7.8.1? How come not just >=8?

Copy link
Member Author

@yakutovicha yakutovicha Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure the existing dependency stacks work, I guess. I cannot imagine the possible set of software combinations this will go into, so it makes sense to keep both for the time being.

Copy link
Contributor

@danielhollas danielhollas Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, most of the apps I think pin the version to 7.x so we must support both for now.

Copy link
Contributor

@danielhollas danielhollas Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as in the AWB PR. Is there anyway we can still support 7.7?
(although this is less pressing here, since aiidalab-home is installed in the image, so whatever minimum version we put here will be the minimum version in the image.

traitlets~=5.0
widgetsnbextension<3.6.3
notebook~=6.0
python_requires = >=3.9

Expand Down