Enable ipywidgets 8.x #207
Conversation
yakutovicha
requested review from
danielhollas,
edan-bainglass and
superstar54
| aiidalab>=v21.10.2 | ||
| ipython~=7.0 | ||
| ipywidgets~=7.6 | ||
| ipywidgets>=7.8.1,<9 |
There was a problem hiding this comment.
So we still support 7.8.1? How come not just >=8?
There was a problem hiding this comment.
To ensure the existing dependency stacks work, I guess. I cannot imagine the possible set of software combinations this will go into, so it makes sense to keep both for the time being.
There was a problem hiding this comment.
Yes, most of the apps I think pin the version to 7.x so we must support both for now.
There was a problem hiding this comment.
Same question as in the AWB PR. Is there anyway we can still support 7.7?
(although this is less pressing here, since aiidalab-home is installed in the image, so whatever minimum version we put here will be the minimum version in the image.
|
I believe this one was a blocker last time we tried this. |
No more blockers :) |
danielhollas
left a comment
danielhollas
left a comment
There was a problem hiding this comment.
Some questions about the changes
| ipw.dlink( | ||
| (self.app, "available_versions"), | ||
| (self.version_selector.version_to_install, "index"), | ||
| transform=lambda versions: 0 if versions else None, |
There was a problem hiding this comment.
A little confused here: is 0 an index and therefore the latest version is selected by default? Maybe worth a comment.
(also why was this not necessary before?).
| self.page_selector.options = list( | ||
| range(1, int(len(self.apps_to_display) / self.items_per_page.value + 2)) | ||
| ) | ||
| self.page_selector.value = 1 |
There was a problem hiding this comment.
I am very confused by this. 😅 why 1?
| aiidalab>=v21.10.2 | ||
| ipython~=7.0 | ||
| ipywidgets~=7.6 | ||
| ipywidgets>=7.8.1,<9 |
There was a problem hiding this comment.
Same question as in the AWB PR. Is there anyway we can still support 7.7?
(although this is less pressing here, since aiidalab-home is installed in the image, so whatever minimum version we put here will be the minimum version in the image.
fix #149