Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions OWNERS

This file was deleted.

40 changes: 34 additions & 6 deletions docs/governance/community_membership.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,40 @@ There are currently two roles for this project, but that may grow in the future.
| Role | Responsibilities | Requirements | Defined by |
|--------------|----------------------------------|--------------------------------------------------------------------|-------------------------------------------------------------------------|
| Collaborator | Can have tickets assigned | Have one PR merged | Read access to the Agones repository |
| Releaser | Create Agones releases | Sponsored by 2 approvers | Commit access to the Agones repository |
| Approver | Review and approve contributions | Sponsored by 2 approvers and multiple contributions to the project | Commit access to the Agones repository and [OWNERS] file approver entry |
| Releaser | Create Agones releases | Sponsored by 2 approvers | Commit access to the Agones repository and listed in this document |
| Approver | Review and approve contributions | Sponsored by 2 approvers and multiple contributions to the project | Commit access to the Agones repository and listed in this document |


## Current Members

### @Approvers
_Members of Team @Approvers_
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme know what you think of putting the team here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List looks good to me, that Owners file was several years stale :) Out of curiosity why the change from an Owners file? That seems to be the more standard format, at least for K8s.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owners file is (AFAIK)specific to Prow, which we don't use (although we did try!)

Also, CNCF is working on https://github.com/cncf/automation/tree/main/utilities/dot-project - which will end up being the ultimate source of truth for us (we'll make our own), but one thing at a time - we needed a list to get started, and we can always adjust over time.


- @markmandel
- @igooch
- @lacroixthomas
- @vicentefb

### Releasers - @Releasers

_Members of Team @Releasers_

- @Sivasankaran25
- @indurireddy-TF

### Approver Emeritus

- @cyriltovena
- @EricFortin
- @gongmax
- @peterzhongyi
- @roberthbailey
- @aLekSer
- @joeholley
- @jkowalski
- @ilkercelikyilmaz
- @pooneh-m

## New contributors

New contributors should be welcomed to the community by existing members,
Expand Down Expand Up @@ -52,7 +82,7 @@ and as such are not expected to perform code reviews or merge PRs. Using their
commit privileges above and beyond creating releases is grounds for revoking
commit access and being demoted from being a releaser.

**Defined by:** Commit access to the Agones repository.
**Defined by:** Commit access to the Agones repository and listed in this document.

### Requirements

Expand Down Expand Up @@ -83,7 +113,7 @@ holistic acceptance of a contribution including: backwards / forwards
compatibility, adhering to API and flag conventions, subtle performance and
correctness issues, interactions with other parts of the system, etc.

**Defined by:** Commit access to the Agones repository and [OWNERS] file approver entry.
**Defined by:** Commit access to the Agones repository and listed in this document.

**Note:** Acceptance of code contributions requires at least one approver.

Expand Down Expand Up @@ -116,5 +146,3 @@ correctness issues, interactions with other parts of the system, etc.
- Assigned PRs to review related based on expertise
- Granted commit access to Agones repo

[OWNERS]: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md

Loading