fix: coffee agentcy docs with new SLIM group communication changes#271
Closed
Shridhar-2205 wants to merge 4 commits into
Closed
fix: coffee agentcy docs with new SLIM group communication changes#271Shridhar-2205 wants to merge 4 commits into
Shridhar-2205 wants to merge 4 commits into
Conversation
Shridhar-2205
force-pushed
the
fix-coffee-agntcy-docs
branch
from
d4b90b9 to
0d9516a
Compare
panyuenlau
reviewed
Oct 3, 2025
Signed-off-by: Shridhar Shah <shridhsh@cisco.com>
Signed-off-by: Shridhar Shah <shridhsh@cisco.com>
Shridhar-2205
force-pushed
the
fix-coffee-agntcy-docs
branch
from
15e1a3e to
91850cd
Compare
jparello
approved these changes
Oct 3, 2025
nandu-gh
approved these changes
Oct 3, 2025
muscariello
reviewed
Oct 4, 2025
muscariello
left a comment
muscariello
left a comment
Member
There was a problem hiding this comment.
I am not sure this is the right way. SLIM v0.6 but also v0.5 supports tight integration w/ RPC protocols. I am not sure if pubsub as currently used makes a lot of sense.
Member
|
Yep good call out, we saw that in 0.5 and 0.6 — we haven’t moved to it yet. Once we get there, we’ll definitely look at pub/sub again. Would it be a problem in your view to keep it for 0.4? I'm feeling a new issue to go over what we all want to see in 0.6 integration. |
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
Member
|
Is this effected by the latest slim release? v0.6.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CoffeeAgntcy docs with new changes in SLIM v0.4.0 and group communication