Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todoist update function + validation fixes #2365

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Conversation

Ansub
Copy link
Member

@Ansub Ansub commented Mar 11, 2025

Description

  • Summary of changes: Describe the key changes in this PR and their purpose.
  • Related issues: Mention if this PR fixes or is connected to any issues.
  • Motivation and context: Explain the reason for the changes and the problem they solve.
  • Environment or dependencies: Specify any changes in dependencies or environment configurations required for this update.
  • Impact on metrics: (If applicable) Describe changes in any metrics or performance benchmarks.

Fixes # (issue)


Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update (Addition or modification of models)
  • Other (please describe):

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).

Ansub added 2 commits March 11, 2025 20:14
- Simplify task update logic to return success status
- Add support for nested kwargs dictionary
- Improve error handling and logging
- Reduce verbosity of task update response
- Add `_task_to_dict()` method to centralize task dictionary conversion
- Reduce code duplication in task-related methods
- Improve type hinting for task conversion
- Simplify task retrieval and creation methods
@Ansub Ansub requested a review from a team as a code owner March 11, 2025 16:44
Copy link
Contributor

@ysolanky ysolanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dirkbrnd dirkbrnd merged commit 3100c60 into main Mar 12, 2025
2 checks passed
@dirkbrnd dirkbrnd deleted the todoist-update-def-fix branch March 12, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants