Todoist update function + validation fixes (#2365)

## Description

- **Summary of changes**: Describe the key changes in this PR and their
purpose.
- **Related issues**: Mention if this PR fixes or is connected to any
issues.
- **Motivation and context**: Explain the reason for the changes and the
problem they solve.
- **Environment or dependencies**: Specify any changes in dependencies
or environment configurations required for this update.
- **Impact on metrics**: (If applicable) Describe changes in any metrics
or performance benchmarks.

Fixes # (issue)

---

## Type of change

Please check the options that are relevant:

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Model update (Addition or modification of models)
- [ ] Other (please describe):

---

## Checklist

- [ ] Adherence to standards: Code complies with Agno’s style guidelines
and best practices.
- [ ] Formatting and validation: You have run `./scripts/format.sh` and
`./scripts/validate.sh` to ensure code is formatted and linted.
- [ ] Self-review completed: A thorough review has been performed by the
contributor(s).
- [ ] Documentation: Docstrings and comments have been added or updated
for any complex logic.
- [ ] Examples and guides: Relevant cookbook examples have been included
or updated (if applicable).
- [ ] Tested in a clean environment: Changes have been tested in a clean
environment to confirm expected behavior.
- [ ] Tests (optional): Tests have been added or updated to cover any
new or changed functionality.

---

## Additional Notes

Include any deployment notes, performance implications, security
considerations, or other relevant information (e.g., screenshots or logs
if applicable).

Author: Ansub

libs/agno/agno/tools/todoist.py

@@ -1,6 +1,6 @@
 import json
 import os
-from typing import List, Optional
+from typing import Any, Dict, List, Optional
 
 from agno.tools import Toolkit
 from agno.utils.log import logger
@@ -61,6 +61,32 @@ def __init__(
         if get_projects:
             self.register(self.get_projects)
 
+    def _task_to_dict(self, task: Any) -> Dict[str, Any]:
+        """Convert a Todoist task to a dictionary with proper typing."""
+        task_dict: Dict[str, Any] = {
+            "id": task.id,
+            "content": task.content,
+            "description": task.description,
+            "project_id": task.project_id,
+            "section_id": task.section_id,
+            "parent_id": task.parent_id,
+            "order": task.order,
+            "priority": task.priority,
+            "url": task.url,
+            "comment_count": task.comment_count,
+            "creator_id": task.creator_id,
+            "created_at": task.created_at,
+            "labels": task.labels,
+        }
+        if task.due:
+            task_dict["due"] = {
+                "date": task.due.date,
+                "string": task.due.string,
+                "datetime": task.due.datetime,
+                "timezone": task.due.timezone,
+            }
+        return task_dict
+
     def create_task(
         self,
         content: str,
@@ -87,28 +113,7 @@ def create_task(
                 content=content, project_id=project_id, due_string=due_string, priority=priority, labels=labels or []
             )
             # Convert task to a dictionary and handle the Due object
-            task_dict = {
-                "id": task.id,
-                "content": task.content,
-                "description": task.description,
-                "project_id": task.project_id,
-                "section_id": task.section_id,
-                "parent_id": task.parent_id,
-                "order": task.order,
-                "priority": task.priority,
-                "url": task.url,
-                "comment_count": task.comment_count,
-                "creator_id": task.creator_id,
-                "created_at": task.created_at,
-                "labels": task.labels,
-            }
-            if task.due:
-                task_dict["due"] = {
-                    "date": task.due.date,
-                    "string": task.due.string,
-                    "datetime": task.due.datetime,
-                    "timezone": task.due.timezone,
-                }
+            task_dict = self._task_to_dict(task)
             return json.dumps(task_dict)
         except Exception as e:
             logger.error(f"Failed to create task: {str(e)}")
@@ -118,28 +123,7 @@ def get_task(self, task_id: str) -> str:
         """Get a specific task by ID."""
         try:
             task = self.api.get_task(task_id)
-            task_dict = {
-                "id": task.id,
-                "content": task.content,
-                "description": task.description,
-                "project_id": task.project_id,
-                "section_id": task.section_id,
-                "parent_id": task.parent_id,
-                "order": task.order,
-                "priority": task.priority,
-                "url": task.url,
-                "comment_count": task.comment_count,
-                "creator_id": task.creator_id,
-                "created_at": task.created_at,
-                "labels": task.labels,
-            }
-            if task.due:
-                task_dict["due"] = {
-                    "date": task.due.date,
-                    "string": task.due.string,
-                    "datetime": task.due.datetime,
-                    "timezone": task.due.timezone,
-                }
+            task_dict = self._task_to_dict(task)
             return json.dumps(task_dict)
         except Exception as e:
             logger.error(f"Failed to get task: {str(e)}")
@@ -152,38 +136,22 @@ def update_task(self, task_id: str, **kwargs) -> str:
         Args:
             task_id: The ID of the task to update
             **kwargs: Any task properties to update (content, due_string, priority, etc.)
+                If a nested 'kwargs' dictionary is provided, its contents will be used instead.
 
         Returns:
-            str: JSON string containing the updated task
+            str: JSON string containing success status
         """
         try:
-            task = self.api.update_task(task_id=task_id, **kwargs)
-            task_dict = {
-                "id": task.id,
-                "content": task.content,
-                "description": task.description,
-                "project_id": task.project_id,
-                "section_id": task.section_id,
-                "parent_id": task.parent_id,
-                "order": task.order,
-                "priority": task.priority,
-                "url": task.url,
-                "comment_count": task.comment_count,
-                "creator_id": task.creator_id,
-                "created_at": task.created_at,
-                "labels": task.labels,
-            }
-            if task.due:
-                task_dict["due"] = {
-                    "date": task.due.date,
-                    "string": task.due.string,
-                    "datetime": task.due.datetime,
-                    "timezone": task.due.timezone,
-                }
-            return json.dumps(task_dict)
+            # Check if there's a nested kwargs dictionary and use it if present
+            if len(kwargs) == 1 and "kwargs" in kwargs and isinstance(kwargs["kwargs"], dict):
+                kwargs = kwargs["kwargs"]
+
+            success = self.api.update_task(task_id=task_id, **kwargs)
+            return json.dumps({"success": success})
         except Exception as e:
-            logger.error(f"Failed to update task: {str(e)}")
-            return json.dumps({"error": str(e)})
+            error_msg = str(e)
+            logger.error(f"Failed to update task: {error_msg}")
+            return json.dumps({"error": error_msg})
 
     def close_task(self, task_id: str) -> str:
         """Mark a task as completed."""
@@ -209,28 +177,7 @@ def get_active_tasks(self) -> str:
             tasks = self.api.get_tasks()
             tasks_list = []
             for task in tasks:
-                task_dict = {
-                    "id": task.id,
-                    "content": task.content,
-                    "description": task.description,
-                    "project_id": task.project_id,
-                    "section_id": task.section_id,
-                    "parent_id": task.parent_id,
-                    "order": task.order,
-                    "priority": task.priority,
-                    "url": task.url,
-                    "comment_count": task.comment_count,
-                    "creator_id": task.creator_id,
-                    "created_at": task.created_at,
-                    "labels": task.labels,
-                }
-                if task.due:
-                    task_dict["due"] = {
-                        "date": task.due.date,
-                        "string": task.due.string,
-                        "datetime": task.due.datetime,
-                        "timezone": task.due.timezone,
-                    }
+                task_dict = self._task_to_dict(task)
                 tasks_list.append(task_dict)
             return json.dumps(tasks_list)
         except Exception as e:

libs/agno/tests/unit/tools/test_todoist_tools.py

@@ -130,28 +130,12 @@ def test_get_task_success(todoist_tools, mock_todoist_api):
 
 def test_update_task_success(todoist_tools, mock_todoist_api):
     """Test successful task update."""
-    mock_task = Mock()
-    mock_task.id = "123"
-    mock_task.content = "Updated Task"
-    mock_task.description = "Updated Description"
-    mock_task.project_id = "project_1"
-    mock_task.section_id = None
-    mock_task.parent_id = None
-    mock_task.order = 1
-    mock_task.priority = 1
-    mock_task.url = "https://todoist.com/task/123"
-    mock_task.comment_count = 0
-    mock_task.creator_id = "user_1"
-    mock_task.created_at = "2024-01-01T10:00:00Z"
-    mock_task.labels = []
-    mock_task.due = None
-
-    mock_todoist_api.update_task.return_value = mock_task
+    mock_todoist_api.update_task.return_value = True
 
     result = todoist_tools.update_task("123", content="Updated Task")
     result_data = json.loads(result)
 
-    assert result_data["id"] == "123"
+    assert result_data["success"] is True
     mock_todoist_api.update_task.assert_called_once_with(task_id="123", content="Updated Task")