Skip to content

Relayer: Rename handleUnprofitableFill to handleUnfillableDeposit and remove outdated TODO #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Open

Relayer: Rename handleUnprofitableFill to handleUnfillableDeposit and remove outdated TODO #2650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/relayer/Relayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ export class Relayer {
this.lastLogTime = currentTime;
}
if (profitClient.anyCapturedUnprofitableFills()) {
this.handleUnprofitableFill();
this.handleUnfillableDeposit();
this.lastLogTime = currentTime;
}
}
Expand Down Expand Up @@ -1469,10 +1469,7 @@ export class Relayer {
return { symbol, decimals, formatter: createFormatFunction(2, 4, false, decimals) };
}

// TODO: This should really be renamed to "handleUnfillableDeposit" since it not only logs about unprofitable relayer
// fees but also about fills with messages that fail to simulate and deposits from lite chains that are
// over-allocated.
private handleUnprofitableFill() {
private handleUnfillableDeposit() {
const { profitClient } = this.clients;
const unprofitableDeposits = profitClient.getUnprofitableFills();

Expand Down Expand Up @@ -1533,7 +1530,7 @@ export class Relayer {

if (mrkdwn) {
this.logger[this.config.sendingRelaysEnabled ? "warn" : "debug"]({
at: "Relayer::handleUnprofitableFill",
at: "Relayer::handleUnfillableDeposit",
message: "Not relaying unprofitable deposits 🙅‍♂️!",
mrkdwn,
notificationPath: "across-unprofitable-fills",
Expand Down