Skip to content

Relayer: Rename handleUnprofitableFill to handleUnfillableDeposit and remove outdated TODO #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Relayer: Rename handleUnprofitableFill to handleUnfillableDeposit and remove outdated TODO #2650

wants to merge 1 commit into from
+3 −6

Conversation

@maradini77
Copy link

@maradini77 maradini77 commented Oct 5, 2025

Rename a private method to accurately reflect its behavior and remove an outdated TODO comment.

Rationale

  • The method handles more than unprofitable fills (e.g., failed simulations, lite-chain over-allocation). Clear naming reduces cognitive load and prevents misuse.

Changes

  • Renamed handleUnprofitableFill → handleUnfillableDeposit.
  • Updated the single call site and the at field in logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@james-a-morris james-a-morris Awaiting requested review from james-a-morris

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@bmzig bmzig Awaiting requested review from bmzig bmzig is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maradini77