Migrate the DICOM study importer to pathlib.Path (path PR 1)
#1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeBICMTL
added
Language: Python
MaximeBICMTL
changed the title
pathlib.Pathpathlib.Path (path PR 1)
jeffersoncasimir
approved these changes
Dec 19, 2025
Contributor
jeffersoncasimir
left a comment
jeffersoncasimir
left a comment
There was a problem hiding this comment.
I proofread the Files changed and it LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
pathlib.Pathinstead ofstrandos.pathin the DICOM study importer.The migration is rather straightforward and the code is typed, so this was a rather easy change. There is no breaking change from a user perspective.
Testing
Tested manually + the code is strictly typed + there are integration tests for the related scripts, so I think it's good.