Migrate ORM to pathlib.Path (path PR 2)
#1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1349
Description
Migrate the ORM models and queries from the
strtype for paths, topathlib.Path, and consolidate the ORM around thepathnaming for paths (instead ofpath,rel_path,location...).Testing
Detailed changes
Add a new
StringPathdecorator to translate back and forth between SQL strings and Python paths.Renamings:
DbDicomArchive.source_location->DbDicomArchive.source_pathDbDicomArchive.archive_location->DbDicomArchive.archive_pathDbFile.rel_path->DbFile.pathDbMriProtocolViolatedScan.file_rel_path->DbMriProtocolViolatedScan.file_pathDbMriUpload.upload_location->DbMriUpload.upload_pathDbMriUpload.decompressed_location->DbMriUpload.decompressed_pathDbMriViolationLog.file_rel_path->DbMriViolationLog.file_pathType changes (from
strtoPath):DbDicomArchive.source_pathDbDicomArchive.archive_pathDbFile.pathDbMriProtocolViolatedScan.file_pathDbMriUpload.upload_pathDbMriUpload.decompressed_pathDbMriViolationLog.file_pathDbPhysioChannel.file_pathDbPhysioCoordSystem.file_pathDbPhysioEventFile.file_pathDbPhysioFile.path