-
Notifications
You must be signed in to change notification settings - Fork 52
Add integration tests for EEG BIDS import #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmadjar
merged 3 commits into
aces:main
from
MaximeBICMTL:add_bids_import_eeg_integration_test
Nov 26, 2025
Merged
Add integration tests for EEG BIDS import #1343
cmadjar
merged 3 commits into
aces:main
from
MaximeBICMTL:add_bids_import_eeg_integration_test
Nov 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52ffb0b to
d1d118e
Compare
d074bfc to
37e28d6
Compare
Contributor
Author
|
@jeffersoncasimir I added two commits to this PR:
|
jeffersoncasimir
requested changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting this error:
Traceback (most recent call last):
File "/opt/Loris-MRI/bin/mri/python/loris_eeg_chunker/edf_to_chunks.py", line 43, in <module>
file_type=mne_edf.FileType.EDF,
^^^^^^^^^^^^^^^^
AttributeError: module 'mne.io.edf.edf' has no attribute 'FileType'
mne==1.10.2
Works with latest version (1.11.0). Changed to approved
jeffersoncasimir
approved these changes
Nov 26, 2025
This was referenced Dec 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: CI
Issue or PR related to continuous integration, including automated tests and static checks
Category: Bug
Issue or PR that aims to report or fix a bug
Complexity: Medium
Issue or PR that requires a moderate effort or expertise to implement, review, or test
Language: Python
Issue or PR related to the Python codebase
Package: EEG chunker
PR or issue related to the EEG chunker
Pipeline: BIDS importer
PR or issue related to the BIDS importer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1325
Description
Add integration tests for EEG BIDS import.
For the tests to pass, this PR requires to add the
Face13BIDS dataset to the test S3 bucket asincoming/Face13. Only thesub-OTT166subject is required, theparticipants.tsvfile should contain this:This PR also adds the ability to use project aliases when using
--createsessionin the current BIDS importer to be consistent with the new BIDS importer.Description 2
Since the tests did not work at first, I also added a bugfix in this PR to make the code work with the most recent
mneversion (1.11.0). Note that the code no longer works with the previous version (1.10.x or less).