Batch Maxime PRs #1324
Batch Maxime PRs #1324
Conversation
MaximeBICMTL
force-pushed
the
maxime_changes
branch
from
e1895a8 to
0712a7a
Compare
* add license file * remove license information in code * fix test error
* add project metadata * add license file * remove license information in code * fix test error * move dependencies to pyproject.toml * fix test error
* add build backend allow direct references * update dockerfile
There was a problem hiding this comment.
Approving this PR which is combination of PRs I previously approved individually.
I successfully ran the current aces/main bids_import.py pipeline with these changes.
The test_orm_sql_sync.py integration test can remove a lot of doubt that might surround the robustness of the ORM transition.
The majority of the rest of the python changes are minor changes regarding standardizing the license and referencing the new config location. For perl it's similar, but regarding the config file reference and enforcing whitespace consistency.
I think this is ready to be merged and I will be testing the Incremental BIDS Importer PR next, which is rebased on this one and now much more digestible
|
@jeffersoncasimir @MaximeBICMTL Two questions coming from testing the BIDS import on CBIGR today, not sure if that has implications on the PRs sent to this repo:
Maybe those are just happening on CBIGR but just in case, figured I would mention it here. |
|
Hi @cmadjar, thank you for your feedback on the BIDS importer! Though note that this PR does not contain changes to the BIDS importer, the BIDS importer used in C-BIG and that I want to merge here is #1325. This PR only contains general changes that do not affect the behavior of individual scripts. I answered your points in the relevant BIDS importer PR. |
This PR batches several of my PRs for easier testing and rebasing. The code of all the PRs included in this branch have been reviewed and approved by @jeffersoncasimir.
DO NOT SQUASH WHEN MERGING so that each individual PR appears in the git history.