Skip to content

Add the EEG chunker to the linter configuration #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmadjar merged 2 commits into from
Nov 6, 2025
Merged

Add the EEG chunker to the linter configuration #1327

cmadjar merged 2 commits into from
Nov 6, 2025

Conversation

@MaximeBICMTL
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL commented Nov 4, 2025 •
edited
Loading

Description

Title. Add the EEG chunker to the linter configuration. Generated code (protocol_buffers) is still excluded from the linter configuration.

  • The first commit adds the EEG chunker to the linter configuration.
  • The second commit fixes the various lints that appeared.

@MaximeBICMTL MaximeBICMTL marked this pull request as draft November 4, 2025 06:02
@MaximeBICMTL MaximeBICMTL changed the title Add EEG chunker to the linter configuration Add the EEG chunker to the linter configuration Nov 4, 2025
@MaximeBICMTL MaximeBICMTL added Language: Python Issue or PR related to the Python codebase Area: CI Issue or PR related to continuous integration, including automated tests and static checks Complexity: Simple Issue or PR that should be simple to implement, review, or test Area: EEG Issue or PR related to EEG / iEEG processing labels Nov 4, 2025
@MaximeBICMTL MaximeBICMTL force-pushed the add_eeg_chunker_to_linter branch from 13b97d3 to a0b39ab Compare November 5, 2025 06:28
@MaximeBICMTL MaximeBICMTL marked this pull request as ready for review November 5, 2025 10:49
@MaximeBICMTL MaximeBICMTL added Package: EEG chunker PR or issue related to the EEG chunker and removed Area: EEG Issue or PR related to EEG / iEEG processing labels Nov 5, 2025
@cmadjar cmadjar merged commit 01ff929 into aces:main Nov 6, 2025
9 checks passed
@cmadjar cmadjar added this to the 28.0.0 milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees

No one assigned

Labels

Area: CI Issue or PR related to continuous integration, including automated tests and static checks Complexity: Simple Issue or PR that should be simple to implement, review, or test Language: Python Issue or PR related to the Python codebase Package: EEG chunker PR or issue related to the EEG chunker

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MaximeBICMTL @cmadjar