Skip to content

Commit

Permalink
[Python] Remove --parallel from cmake --build command in setup.py
Browse files Browse the repository at this point in the history
Causes problems due to unlimited parallel compilation with make.
Better let this be controlled by setting CMAKE_BUILD_PARALLEL_LEVEL
environment variable, which only works if --parallel option is not
passed in the command line.

https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html

Fixes: xrootd#2356
  • Loading branch information
amadio committed Oct 28, 2024
1 parent 6fb6440 commit ef19db1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bindings/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def build_extensions(self):
os.makedirs(self.build_temp)

check_call([cmake, ext.src, '-B', self.build_temp] + cmake_args)
check_call([cmake, '--build', self.build_temp, '--parallel'])
check_call([cmake, '--build', self.build_temp])

version = get_version()

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def build_extensions(self):
os.makedirs(self.build_temp)

check_call([cmake, ext.src, '-B', self.build_temp] + cmake_args)
check_call([cmake, '--build', self.build_temp, '--parallel'])
check_call([cmake, '--build', self.build_temp])

version = get_version()

Expand Down

0 comments on commit ef19db1

Please sign in to comment.