fix(security): complete Windows tirith install support#5
Open
XiaoXiao0221 wants to merge 2 commits into
Open
Conversation
…tirith binary - Add Windows platform detection in _detect_target() (pc-windows-msvc) - Use .zip archive for Windows targets instead of .tar.gz - Implement zipfile extraction for Windows binary (tirith.exe) - Fix path resolution bug where src_base ignored nested zip members - Skip chmod +x on Windows (not supported) - Add unit test script for cross-platform archive handling Fixes: WinError 2 file not found when tirith auto-installs on Windows
This was referenced Apr 12, 2026
XiaoXiao0221
pushed a commit
that referenced
this pull request
Apr 14, 2026
…Research#9326) - Rename 'AI Gateway' to 'Vercel AI Gateway' across auth, models, doctor, setup, and tests. - Move Xiaomi MiMo to position #5 in the provider picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes Windows auto-install support for the
tirith_securitytool.On Windows,
tirithreleases use.ziparchives and installtirith.exeinstead oftirith. The original code only handled Linux/macOS archive and binary conventions, which caused auto-install to fail. This PR adds the Windows archive/install path and also fixes the follow-up resolution path so Hermes can keep finding the installed binary under$HERMES_HOME/binafter installation or on later runs.Related Issue
Fixes the Windows
WinError 2auto-install failure for the Tirith security scanner.Type of Change
Changes Made
tools/tirith_security.py(pc-windows-msvc).ziparchives for Windows while keeping.tar.gzfor Linux/macOStirith.exefrom Windows release archives and skip Unix-stylechmodon Windows$HERMES_HOME/bin/tirith.exeafter install and after restarttests/tools/test_tirith_security.pyand remove the standalone ad-hoc test scriptHow to Test
python -m pytest tests/tools/test_tirith_security.py -q -n 0.ziprelease and installstirith.exe$HERMES_HOME/bin/tirith.exeon a later run without reinstallingChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
python -m pytest tests/tools/test_tirith_security.py -q -n 0->66 passed in 1.54son Windowstirith.exe