fix(security): add Windows archive detection and .zip extraction for tirith binary#1
Closed
XiaoXiao0221 wants to merge 2 commits into
Closed
fix(security): add Windows archive detection and .zip extraction for tirith binary#1XiaoXiao0221 wants to merge 2 commits into
XiaoXiao0221 wants to merge 2 commits into
Conversation
Add OSError to os.kill(pid, 0) exception handling in gateway/status.py
…tirith binary - Add Windows platform detection in _detect_target() (pc-windows-msvc) - Use .zip archive for Windows targets instead of .tar.gz - Implement zipfile extraction for Windows binary (tirith.exe) - Fix path resolution bug where src_base ignored nested zip members - Skip chmod +x on Windows (not supported) - Add unit test script for cross-platform archive handling Fixes: WinError 2 file not found when tirith tries to auto-install on Windows
Owner
Author
|
Closed - replaced by clean PR #5 (only tirith changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WinError 2 when tirith security scanner tries to auto-install on Windows.
Problem
The tirith_security tool only supported Linux/macOS (.tar.gz archives). On Windows, _detect_target() returned None and all archives were assumed to be .tar.gz, but GitHub releases for Windows are .zip format.
Changes
Test Plan
Platforms Tested