chore: Deprecated old theming utilities #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-deprecate-theming-utils
|
| Run status |
|
| Run duration | 02m 53s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
86
|
Skipped
|
0
|
Passing
|
843
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.41%
|
|
|---|---|
|
Untested elements
|
1526
|
|
Tested elements
|
365
|
Accessibility
99.31%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
77
|
alanbsmith
reviewed
Oct 10, 2025
| import {memoize} from '../utils/memoize'; | ||
|
|
||
| /** | ||
| * @deprecated ⚠️ `shiftColor` is deprecated and will be removed in a future major version. While we work on a algorithm for color shifting, you can use |
alanbsmith
requested changes
Oct 10, 2025
| } | ||
|
|
||
| /** | ||
| * @deprecated ⚠️ `styled` is deprecated and will be removed in a future major version. Please use `createStyles` or `createStencil` instead with [CSS logical properties](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values). For more information, view our [Styling docs](https://workday.github.io/canvas-kit/?path=/docs/styling-getting-started-overview--docs). |
There was a problem hiding this comment.
YES. FI-NA-LLY. It's happening.
Co-authored-by: Alan B Smith <[email protected]>
mannycarrera4
commented
Oct 10, 2025
| import {memoize} from '../utils/memoize'; | ||
|
|
||
| /** | ||
| * @deprecated ⚠️ `shiftColor` is deprecated and will be removed in a future major version. While we work on a algorithm for color shifting, you can use |
There was a problem hiding this comment.
Suggested change
| * @deprecated ⚠️ `shiftColor` is deprecated and will be removed in a future major version. While we work on a algorithm for color shifting, you can use | |
| * @deprecated ⚠️ `shiftColor` is deprecated and will be removed in a future major version. While we work on a algorithm for color shifting, you can use [oklch with calc or from](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/oklch) to choose colors. |
mannycarrera4
commented
Oct 10, 2025
mannycarrera4
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3518
Release Category
Utilities
Release Note
The following theming utils have been deprecated:
defaultCanvasThemestyledcreateCanvasThemegetThemeuseThemeuseIsRTLuseThemedRingTo better support our theming we encourage our consumers to use our CSS Tokens. For more information, please view our Theming Docs and CSS Token docs.
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)