-
Notifications
You must be signed in to change notification settings - Fork 8
Saved tones #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Saved tones #7
Conversation
|
Is there a reason we couldn't just reuse the AlertTone box for this? That would allow us to keep all the same logic. You could use a property in the class to tell it if it is a tone box or not. |
There was no specific reason just did not even think of that and to be honest this was my first time messing with c# so did not wanna break things that were working and give more work for my self if you want I can do more edits and see what I can do when I'm back as I'm off for few days taking so time to myself for personal reasons but if you guys want to do it you can just figured it's just easier for me to do it the way I have until I get a hang of c# |
|
It should be pretty easy to just reuse the existing stuff. I would really rather see that. |
Sounds good will give it a go when I'm back later this week as I previously state I'm off for few days taking personal time but also another reason why I did it the way I did was due to the tone stacking I logic I started working on (Not in the code) |
|
I’m sure you can figure out how to add the multi tone support to the existing boxes. Just need to maintain a state internally in the box of which it identifies as. Tone box, multi tone box, or alert tone. |
i have added the Multi-Tone Support |
Uh oh!
There was an error while loading. Please reload this page.