Skip to content

Saved Tones, Multi Tone Paging, UI Redesign #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DeathSoulYTDev wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Saved Tones, Multi Tone Paging, UI Redesign #9

DeathSoulYTDev wants to merge 17 commits into from

Conversation

@DeathSoulYTDev
Copy link

@DeathSoulYTDev DeathSoulYTDev commented Aug 6, 2025

  • Added Support For Multi Tone Paging

@DeathSoulYTDev
Add files via upload
f2bea89
@DeathSoulYTDev
Add files via upload
9b56619
@DeathSoulYTDev
Update codeplug.yml
85b94b3
@DeathSoulYTDev
Add files via upload
6c59a03
@DeathSoulYTDev
Added Multi Tone Paging - QC 2
aef12a6
@DeathSoulYTDev
Tones Delay
4d73207 
- Removed Delay for First Tone When Using Stacked Tones
- Lowered the Delay from 2000ms to 1750ms
@DeathSoulYTDev
Zone Tabs
d44cfc3 
- Loaded Zones and there channels into there own tabs
- Added a Zones Filter to QC2 Tones to allow setting Tones Per Zone/Agency
@DeathSoulYTDev
Updated WLLib
76ed6f4
firealarmss
firealarmss requested changes Aug 21, 2025
View reviewed changes
@DeathSoulYTDev
Comments Removal & Tone Delay
33bda3b 
- Removed All Unused/Old Code that was Commented Out
- Fixed the Stacked Tones Delay so its not delaying the First Tone
@DeathSoulYTDev
UI Fix
087a8e1 
- Fixed Canvas Sizing When Window Resizes
- Auto Added A SYSTEMS Tab for Show a Playback Channel and SystemBoxes
@DeathSoulYTDev
Comments Removal
c414ef0 
- Removed Forgotten Commented out Code
@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Aug 21, 2025

i have Updated the the code and removed all unneeded code that was commented out i have also fixed the UI Bug with tabs

@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Aug 22, 2025

This has also been tested with the fivem script and I have confirmed that it works

@DeathSoulYTDev
Update/Bug Fixes
d12efcb 
- Fixed The Global Ptt & Alert Tone 3 Buttons as they where previously swaped Somehow
- Updated Styling Of the Channels Groups/ZoneTabs
- Updated Styling to a Dark Mode
@DeathSoulYTDev
Update README.md
8581ef1
@DeathSoulYTDev
Update README.md
9fc3fa0
@DeathSoulYTDev
Update README.md
ed8088a
@DeathSoulYTDev
Update image in README for WhackerLink Console V2
8e17790
@Firav
Copy link

Firav commented Dec 15, 2025

@firealarmss My suggestion would be to close this PR and #7.
@DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Dec 15, 2025

@firealarmss My suggestion would be to close this PR and #7. @DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

everything from 7 should be in this PR and as for changes on 7 what where those changes not addressed? as i do remember fixing it all

@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Dec 15, 2025

i can also rename this PR and add a list of what was changed & addedd

@DeathSoulYTDev DeathSoulYTDev changed the title Multi Tone Paging Saved Tonesm Multi Tone Paging, UI Redesign Dec 15, 2025
@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Dec 15, 2025 •
edited
Loading

PR Changes

  • Added Support for Saving QC2 Tones
  • Added Channel Sorting VIA Zone/Department Tabs,
  • Filtered QC2 Tones Through Zone/Department Tabs to sit in same Tab and the Corresponding Channel
  • Made QC2 Tone Boxes Draggable Along with Channel Boxes
  • Redesigned The Console's Whole UI into a Dark Theme

Thats what was added & changed

@Firav
Copy link

Firav commented Dec 15, 2025

@firealarmss My suggestion would be to close this PR and #7. @DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

everything from 7 should be in this PR and as for changes on 7 what where those changes not addressed? as i do remember fixing it all

If thats the case, when using this PR as snapshot and attempting to load a codeplug with the tones: array results in a parsing error and crash. Works fine with the branch #7 is based on, just not this one.

@firealarmss Is there a reason we couldn't just reuse the AlertTone box for this? That would allow us to keep all the same logic. You could use a property in the class to tell it if it is a tone box or not.

This was never addressed, you are still using new objects, not the AlertTone box.

@DeathSoulYTDev DeathSoulYTDev changed the title Saved Tonesm Multi Tone Paging, UI Redesign Saved Tones, Multi Tone Paging, UI Redesign Dec 15, 2025
@DeathSoulYTDev
Copy link
Author

DeathSoulYTDev commented Dec 15, 2025 •
edited
Loading

If thats the case, when using this PR as snapshot and attempting to load a codeplug with the tones: array results in a parsing error and crash. Works fine with the branch #7 is based on, just not this one.

Fixed

@firealarmss Is there a reason we couldn't just reuse the AlertTone box for this? That would allow us to keep all the same logic. You could use a property in the class to tell it if it is a tone box or not.
This was never addressed, you are still using new objects, not the AlertTone box.

was not able to find a way to make that work without major rewriting of the component and massive code base issues along side unreadable code so i had to stick with making it its own component

@Firav
Copy link

Firav commented Dec 15, 2025 •
edited
Loading

@DeathSoulYTDev was not able to fix a way to make that work with major rewriting of the component and mass code base issues along side unreadable code so i had to stick with making it its own component

@firealarmss back to you on this one in reference to your requested changes in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@firealarmss firealarmss Awaiting requested review from firealarmss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DeathSoulYTDev @Firav @firealarmss