Skip to content

fix(rich-text-editor): fix link text (VIV-000) #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RichardHelm merged 1 commit into from
Dec 19, 2025
Merged

fix(rich-text-editor): fix link text (VIV-000) #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libs/components/src/lib/rich-text-editor/locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export interface RichTextEditorLocale {
close: string;
edit: string;
delete: string;
clickHere: string;
imageSizes: {
small: string;
fit: string;
Expand Down
5 changes: 4 additions & 1 deletion libs/components/src/lib/rich-text-editor/rte/features/link.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ describe('RteLinkFeature', () => {
);
});

it('should show a popover with a clickable link when the cursor is inside a link', async () => {
it('should show a popover with the link text and clickable URL when the cursor is inside a link', async () => {
const { openPopover, placeCursor, element } = await setup(features, [
p(
'Go to ',
Expand All @@ -164,6 +164,9 @@ describe('RteLinkFeature', () => {
await elementUpdated(element);

expect(openPopover()!.open).toBe(true);
expect(
openPopover()!.querySelector('.link-popover-label')!.textContent
).toBe('our website');
expect(openPopover()!.querySelector('a')!.href).toBe(
'https://example.com/'
);
Expand Down
2 changes: 1 addition & 1 deletion libs/components/src/lib/rich-text-editor/rte/features/link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class RteLinkFeatureImpl extends RteFeatureImpl {
children: [
createText(ctx, {
text: () =>
ctx.rte.getLocale().richTextEditor.clickHere,
this.getCurrentLink(ctx.view.state)?.text || '',
}),
],
}),
Expand Down
1 change: 0 additions & 1 deletion libs/components/src/locales/de-DE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ const deDE: Locale = {
close: 'Schließen',
edit: 'Bearbeiten',
delete: 'Löschen',
clickHere: 'Hier klicken',
imageSizes: {
small: 'Klein',
fit: 'Anpassen',
Expand Down
1 change: 0 additions & 1 deletion libs/components/src/locales/en-GB.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ const enGB: Locale = {
close: 'Close',
edit: 'Edit',
delete: 'Delete',
clickHere: 'Click here',
imageSizes: {
small: 'Small',
fit: 'Fit',
Expand Down
1 change: 0 additions & 1 deletion libs/components/src/locales/en-US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ const enUS: Locale = {
close: 'Close',
edit: 'Edit',
delete: 'Delete',
clickHere: 'Click here',
imageSizes: {
small: 'Small',
fit: 'Fit',
Expand Down
1 change: 0 additions & 1 deletion libs/components/src/locales/ja-JP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ const jaJP: Locale = {
close: '閉じる',
edit: '編集',
delete: '削除',
clickHere: 'ここをクリック',
imageSizes: {
small: '小',
fit: 'フィット',
Expand Down
1 change: 0 additions & 1 deletion libs/components/src/locales/zh-CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ const zhCN: Locale = {
close: '关闭',
edit: '编辑',
delete: '删除',
clickHere: '点击这里',
imageSizes: {
small: '小',
fit: '适应',
Expand Down
Loading