Skip to content

Conversation

@RichardHelm
Copy link
Contributor

No description provided.

@RichardHelm RichardHelm requested a review from Copilot December 10, 2025 17:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused clickHere locale string from the rich-text-editor component and updates the link popover to display the actual link text instead of a generic "Click here" placeholder.

  • Removed clickHere from all locale files (en-US, en-GB, de-DE, ja-JP, zh-CN)
  • Updated link feature to display the current link's text in the popover
  • Enhanced test to verify the link text is displayed correctly

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/components/src/locales/en-US.ts Removed unused clickHere locale string
libs/components/src/locales/en-GB.ts Removed unused clickHere locale string
libs/components/src/locales/de-DE.ts Removed unused clickHere locale string
libs/components/src/locales/ja-JP.ts Removed unused clickHere locale string
libs/components/src/locales/zh-CN.ts Removed unused clickHere locale string
libs/components/src/lib/rich-text-editor/locale.ts Removed clickHere from the locale interface definition
libs/components/src/lib/rich-text-editor/rte/features/link.ts Changed link popover to display actual link text instead of generic locale string
libs/components/src/lib/rich-text-editor/rte/features/link.spec.ts Updated test to verify link text is displayed in popover

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d61b119) to head (636bdef).
⚠️ Report is 1699 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #2650     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       430    +307     
  Lines         1562     10175   +8613     
  Branches       108      1870   +1762     
===========================================
+ Hits          1562     10175   +8613     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants