Skip to content

refactor: improve toBoxArray readability and type safety #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

refactor: improve toBoxArray readability and type safety #4604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/vtable/src/tools/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,21 +236,22 @@ function getIgnoreCase(obj: any, name: string): any {
return undefined;
}

export function toBoxArray<T>(obj: T | T[]): [T, T, T, T] {
type BoxTuple<T> = [top: T, right: T, bottom: T, left: T];
export function toBoxArray<T>(obj: T | T[]): BoxTuple<T> {
if (!Array.isArray(obj)) {
return [obj /*top*/, obj /*right*/, obj /*bottom*/, obj /*left*/];
return [obj, obj, obj, obj];
}
if (obj.length === 3) {
return [obj[0] /*top*/, obj[1] /*right*/, obj[2] /*bottom*/, obj[1] /*left*/];
return [obj[0], obj[1], obj[2], obj[1]];
}
if (obj.length === 2) {
return [obj[0] /*top*/, obj[1] /*right*/, obj[0] /*bottom*/, obj[1] /*left*/];
return [obj[0], obj[1], obj[0], obj[1]];
}
if (obj.length === 1) {
return [obj[0] /*top*/, obj[0] /*right*/, obj[0] /*bottom*/, obj[0] /*left*/];
return [obj[0], obj[0], obj[0], obj[0]];
}
// return obj as [T, T, T, T];//原先这种返回方式，会造成修改引用问题
return [obj[0] /*top*/, obj[1] /*right*/, obj[2] /*bottom*/, obj[3] /*left*/];
return [obj[0], obj[1], obj[2], obj[3]];
}

export { isNode, getChainSafe, applyChainSafe, getOrApply, getIgnoreCase, array };
Expand Down