Add tests for tai calendar - #389
Merged
Merged
Conversation
|
|
Collaborator
|
looks good, thanks Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a (I think) complete set of tests for the tai calendar. I can't (quickly) figure out how to get coverage to work with Cython, so I'm only guessing, but I looked for 'tai' in the source, and tested all that I could find.
It only tests what's unique about tai, assuming the gregorian is already well tested.
I use "raw" pytest tests -- which I find easier to read and write, but will only work with pytest, but it seems you're using pytest, so all good.
But they could be ported to
unittestif you'd like.And a couple other tiny formatting updates ...
Thanks for getting on this!