Conversation
|
@ChrisBarker-NOAA could you take a look? |
ChrisBarker-NOAA
left a comment
There was a problem hiding this comment.
This looks good to me -- thanks Jeff!
It could use some tests, though. maybe I'll find a bit of time to write a couple soon -- but don't wait for me.
|
Hmm -- I'm adding some tests -- stay tuned for that. But looking at the code more, should though it doesn't seem to know which calendar it's using, so I guess not, but there should be a check somewhere. and there is -- before |
|
Looking, I can't tell for sure, but I think that a tai calendar could get a TZInfo attached to it, which should be illegal. |
|
Scratch that -- I see that the cftime.datetime class init doesn't take that keyword anyway. |
|
OK -- I did add tests -- see: #389 Once I was thinking about it, I figured why not? |
Add tests for tai calendar
same as 'proleptic_gregorian', but only valid for dates after 1958-01-01.
exceptions are raised if dates before 1958 are requested or a base date before 1958-01-01 is used.
Tests added by @ChrisBarker-NOAA