Skip to content

Replace bare except clauses with specific exception handling #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: refactor_models
Choose a base branch
from
Draft

Replace bare except clauses with specific exception handling #119

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aa5d64
Initial plan
Copilot Dec 7, 2025
9ec7059
Fix bare except clauses with specific exceptions and explanatory comm…
Copilot Dec 7, 2025
ac2929a
Update comment to accurately reflect exception handling behavior
Copilot Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions timetable/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,8 @@ def trade_match_queue(request, timetable_slug=None):
try:
trade_request = TradeRequest.objects.get(pk=request_id)
timetable_slug = trade_request.offered_allocation.timetable.slug
except:
except TradeRequest.DoesNotExist:
# If trade request doesn't exist, timetable_slug remains None and default view is shown
pass

# Handle trade match (swap)
Expand Down Expand Up @@ -1155,7 +1156,8 @@ def trade_match_queue(request, timetable_slug=None):
try:
trade_match = TradeMatch.objects.get(pk=match_id)
timetable_slug = trade_match.request_1.offered_allocation.timetable.slug
except:
except TradeMatch.DoesNotExist:
# If trade match doesn't exist, timetable_slug remains None and fallback redirect logic applies
pass

if timetable_slug:
Expand Down