Replace bare except clauses with specific exception handling#119
Draft
Copilot wants to merge 3 commits into
Draft
Replace bare except clauses with specific exception handling#119Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…ents Co-authored-by: Foosec <31885466+Foosec@users.noreply.github.com>
Co-authored-by: Foosec <31885466+Foosec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on models refactor and resource groups implementation
Replace bare except clauses with specific exception handling
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #116 regarding bare
except:clauses that silently catch all exceptions without documentation.Changes
except:withexcept TradeRequest.DoesNotExist:when attempting to retrieve timetable_slug from a trade requestexcept:withexcept TradeMatch.DoesNotExist:when attempting to retrieve timetable_slug from a trade matchBefore:
After:
This prevents accidentally catching system exits, keyboard interrupts, and unrelated exceptions while making the code's intent explicit.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.