Repository navigation
Record who answered from the phone's YOLO switch and paired desktops, and test a card open at a crash (CF-6) - #329
Merged
Merged
Conversation
…op answers (CF-6, finding 9) Switching a thread to YOLO answers the approvals already waiting, and each one was saved as answered by this Mac's window even when the phone set YOLO. Answers and policy changes from a desktop paired through the host were also saved as the window's own. - The phone's policy route passes "phone" to setApprovals, and the runner's YOLO switch answers as whoever made the change. - Commands that arrive through the desktop host carry no IPC event, so thread:answer, thread:answer-question and thread:update record "paired-desktop" for them. - The card says "Answered from a paired desktop." under such an answer. Red first: the companion policy test (by was undefined), the answerNote case, the new runner test (updateThread had no by option) and the Store e2e (no note under the paired desktop's approval). Coven-Harness: Claude Code / claude-opus-5-5
…ll (CF-6, finding 3) After a crash the new process closes a card nobody answered only when it first reads that thread. The phone's poll reads its journal cursor before that, so on main at 396b17c the first poll answered delta: true with no items and the card stayed actionable (probe p2 in the #279 review). #309 gives the journal a new id after an unclean shutdown. The phone's old cursor then reloads to a full snapshot, which the same read settles. This test fails on 396b17c ("delta: true, items: 0") and passes with #309's journal. A clean quit, which stops the turn before the journal closes, passes either way and is kept as the control case. Coven-Harness: Claude Code / claude-opus-5-5
… journal docs (CF-6) Coven-Harness: Claude Code / claude-opus-5-5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 of 15 tasks
BunsDev
added a commit
that referenced
this pull request
Oct 20, 2026
Conflicts: - companion.ts: keeps this branch's question notice text and main's fallback notice for an unknown item kind (#329). - docs/human-requests.md: keeps this branch's phone paragraph and main's "Who answered" bullet and paired-desktop window line (#329). journal-resume.test.ts (#309) was written against delivery being recorded the moment an answer is accepted. On this branch a backend confirms its write through sink.deliverRequest, as the mock backend and the runner tests do. Its two fake backends now pass a native request id and write inside deliverRequest, so the crash test still checks that the card reloads answered and the CLI hears one decision. Full desktop unit suite: 1,704 tests, 1,688 passed, 16 skipped, 0 failed. Coven-Harness: Claude Code / claude-opus-5-5
This was referenced Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the CF-6 review on #279: who answered (finding 9) and a card left open at a crash (finding 3).
Who answered (finding 9)
"phone"throughsetApprovals, and the runner's YOLO switch answers as whoever made the change.thread:answer,thread:answer-questionandthread:updaterecord"paired-desktop"for them.docs/human-requests.mdlists the three values and the YOLO rule.A card open at a crash (finding 3)
396b17c, the phone's first poll after a crash answereddelta: truewith 0 items, so the card stayed actionable.test/request-crash.test.tsfails on396b17cand passes on this base, which has Harden the event journal against failed writes, crashes and oversized frames (CF-6, journal mechanics) #309.Red first
bywas undefined);answerNotecase;test/request-attribution.test.ts(updateThreadhad nobyoption);test/request-crash.test.tson396b17c(delta: true, items: 0).Checks (
30ac266, onmainatc345779, which includes #309)pnpm install --frozen-lockfile,pnpm buildandpnpm typecheckall passed.pnpm test: desktop 1,658 tests, with 1,642 passed, 16 skipped (the existing ones) and 0 failed. Every other suite passed: 109, 16, 21, 10 and 16.store-desktop,human-requests,approvals,approval-policy,event-journalandcompanionpassed 20/20, afterpnpm --filter @modex/store-desktop build.Not in this PR
answer().Coven-Harness: Claude Code / claude-opus-5-5