Skip to content

Fix parse range with min constraint #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iimog wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parse range with min constraint #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b3ee0
Add test for min_constraint
iimog Nov 24, 2025
a3a0f87
Fix min_constraint bug in _parse_range
iimog Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchio/transforms/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def _parse_range(
f'If {name} is a single number, it must be of'
f' type {type_constraint}, not {nums_range}',
)
min_range = -nums_range if min_constraint is None else nums_range
min_range = -nums_range if min_constraint is None else min_constraint
return (min_range, nums_range)

try:
Expand Down
4 changes: 4 additions & 0 deletions tests/transforms/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ def test_arguments_are_and_are_not_dict(self):
with pytest.raises(ValueError):
transform.arguments_are_dict()

def test_min_constraint(self):
transform = tio.RandomNoise()
assert transform._parse_range(3, 'name', min_constraint=0) == (0, 3)

def test_bad_over_max(self):
transform = tio.RandomNoise()
with pytest.raises(ValueError):
Expand Down
Loading