Fix parse range with min constraint #1390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iimog
force-pushed
the
1389-fix-parse-range
branch
from
cb706d8 to
a3a0f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389
Description
This pr adds a test that the
min_constraintis properly used in_parse_rangeand fixes the issue in the line, that caused the bug.Checklist
CONTRIBUTINGdocs and have a developer setup readyI did not modify the docstrings or documentation because this change ensures they are accurate. Previously, the described behaviour did not occur (e.g., for RandomNoise, providing a single value for
stdwas supposed to apply a random noise level between 0 andstd, but actually, the maximum value ofstdwas always applied). In this way, it could be considered a breaking change if users actively relied on this behavior.