Skip to content

🐛 Fix Contours with Holes #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

🐛 Fix Contours with Holes #956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e44857
fix contours with holes
measty Sep 19, 2025
33dc025
mypy fix
measty Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tiatoolbox/utils/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ def process_contours(

"""
annotations_list: list[Annotation] = []
outer_contours: list[np.ndarray] = []
outer_contours: dict[int, np.ndarray] = {}
holes_dict: dict[int, list[np.ndarray]] = {}

for i, layer_ in enumerate(contours):
Expand All @@ -1235,7 +1235,7 @@ def process_contours(
# save one points as a line, otherwise save the Polygon
if len(layer_) > 2: # noqa: PLR2004
if int(hierarchy[0][i][3]) == -1: # Outer contour
outer_contours.append(scaled_coords[0])
outer_contours[i] = scaled_coords[0]
else: # Hole
parent_idx: int = int(hierarchy[0][i][3])
if parent_idx not in holes_dict:
Expand Down Expand Up @@ -1274,7 +1274,7 @@ def process_contours(
]
)

for idx, outer in enumerate(outer_contours):
for idx, outer in outer_contours.items():
holes: list[np.ndarray] = holes_dict.get(idx, [])
if len(holes) != 0:
feature_geom = feature2geometry(
Expand Down