Skip to content

Conversation

measty
Copy link
Collaborator

@measty measty commented Sep 19, 2025

This PR fixes the problem of dict_to_store_semantic_segmentor failing to handle holes properly. The problem was, that the code was not associating the holes with the correct parent contour.

For a segmentation mask like:

Screenshot 2025-09-19 023727

Old code would give an annotation store looking like:

Screenshot 2025-09-19 024357

With this PR, that store now looks like:

image

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (3fa051f) to head (33dc025).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #956   +/-   ##
========================================
  Coverage    99.09%   99.09%           
========================================
  Files           71       71           
  Lines         9161     9161           
  Branches      1196     1196           
========================================
  Hits          9078     9078           
  Misses          59       59           
  Partials        24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shaneahmed shaneahmed changed the title fix contours with holes 🐛 Fix Contours with Holes Oct 2, 2025
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @measty

@shaneahmed shaneahmed merged commit 5bb255b into develop Oct 2, 2025
15 checks passed
@shaneahmed shaneahmed deleted the fix-contours-with-holes branch October 2, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants