Better Camera Implementation #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added camera scanner
Added camera ID alongside Serial #
The code is now done, and completely untested. I need teh Orin cameras to be able to test it, and also to test it on the Orin. However, this code should be perfectly just fine and working. The Bash scripts are the only thing entirely untested and possibly not working correctly.
…into cameraIDs
I forgot these on the first time I pushed the code.
maxspier
reviewed
Jan 14, 2025
jamesi8086
reviewed
Jan 14, 2025
jamesi8086
reviewed
Jan 14, 2025
clifflocked
reviewed
Jan 16, 2025
cgpadwick
requested changes
Jan 20, 2025
There was a problem hiding this comment.
At the sunday meeting we decided we need to prioritize integrating with the kalman filter this week. So we're going to descope and read the rotation/translation for each camera from each calibration file, and I'm asking you to add those parameters into those files. We can pick up the implementation later after we've successfully integrated.
Please make the requested changes to the calibration files as soon as possible so we can merge it. This is the highest priority activity on the vision team.
…into cameraIDs
|
This should be ok? |
cgpadwick
approved these changes
Jan 23, 2025
maxspier
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be ok, but strangely both subprocesses appear to be dying for some reason.