Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

add support for CANcoder to MaroonFramework #21

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

dejabot
Copy link
Contributor

@dejabot dejabot commented Jan 27, 2024

Description

Add support for CANcoders to MaroonFramework.

NOTE: this branch is based on the branch that removes several API methods. Will rebase once that PR has been submitted.

How Has This Been Tested?

Will test on Gatorade

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@dejabot dejabot requested a review from rcahoon January 27, 2024 09:08
@dejabot
Copy link
Contributor Author

dejabot commented Jan 29, 2024

for this PR, focus on the new enum in EncoderReader, the changes in RobotProvider and WPIRobotProvider, and the new CANcoderEncoder code. the rest of the changes are from the maroonframework-trim-hal branch which has been sent in a separate PR.

@dejabot
Copy link
Contributor Author

dejabot commented Jan 30, 2024

Thx! PTAL?

@dejabot dejabot force-pushed the maroonframework-add-cancoder branch from 9ee986e to 65f3a9e Compare February 1, 2024 02:08
@dejabot dejabot merged commit 5592608 into main Feb 1, 2024
3 checks passed
@dejabot dejabot deleted the maroonframework-add-cancoder branch February 1, 2024 02:11
The-Arx pushed a commit that referenced this pull request Feb 10, 2024
* start adding support for CANcoder in MaroonFramework

* remove CANcoderEncoder.get()

* add support for CANcoders

* responding to PR comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants