This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
remove some APIs from Encoder, MotorController #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
force-pushed
the
maroonframework-trim-hal
branch
from
e671df5 to
e488784
Compare
|
I guess I reviewed the changes here in #21 |
|
Thx! PTAL? |
rcahoon
approved these changes
Jan 31, 2024
dejabot
force-pushed
the
maroonframework-trim-hal
branch
from
67ea885 to
6ba968f
Compare
The-Arx
pushed a commit
that referenced
this pull request
Feb 10, 2024
* delete some methods from EncoderReader * remove less used ControlModes in MotorController * remove EncoderReader.get() * responding to PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused/less used APIs in Encoder and MotorController. Will make maintaining implementations easier, especially for CTRE devices which have a new API.
How Has This Been Tested?
code deletion - ensuring tree builds and unit tests run