Skip to content

fix: add parent tags to folders_to_tags macro and start tagging at root folder #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix: add parent tags to folders_to_tags macro and start tagging at root folder #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26cc70a
start tagging from root and add parent tags
rsazra May 27, 2025
7d12079
update snapshot to pass test
rsazra May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/tagstudio/qt/modals/folders_to_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ class BranchData:

def add_folders_to_tree(library: Library, tree: BranchData, items: tuple[str, ...]) -> BranchData:
branch = tree
parent_tag = None
for folder in items:
if folder not in branch.dirs:
# TODO: Reimplement parent tags
new_tag = Tag(name=folder)
new_tag = Tag(name=folder, parent_tags=({parent_tag} if parent_tag else None))
library.add_tag(new_tag)
branch.dirs[folder] = BranchData(tag=new_tag)
branch.tag = new_tag
branch = branch.dirs[folder]
parent_tag = branch.tag
return branch


Expand All @@ -71,7 +71,7 @@ def add_tag_to_tree(items: list[Tag]):
add_tag_to_tree(reversed_tag)

for entry in library.get_entries():
folders = entry.path.parts[1:-1]
folders = entry.path.parts[0:-1]
if not folders:
continue

Expand Down Expand Up @@ -124,7 +124,7 @@ def _add_folders_to_tree(items: Sequence[str]) -> BranchData:
add_tag_to_tree(reversed_tag)

for entry in library.get_entries():
folders = entry.path.parts[1:-1]
folders = entry.path.parts[0:-1]
if not folders:
continue

Expand Down
2 changes: 1 addition & 1 deletion tests/qt/__snapshots__/test_folders_to_tags.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# serializer version: 1
# name: test_generate_preview_data
BranchData(dirs={'two': BranchData(dirs={}, files=['bar.md'], tag=<Tag ID: None Name: two>)}, files=[], tag=None)
BranchData(dirs={'one': BranchData(dirs={'two': BranchData(dirs={}, files=['bar.md'], tag=<Tag ID: None Name: two>)}, files=[], tag=<Tag ID: None Name: one>)}, files=[], tag=None)
# ---