Skip to content

fix: add parent tags to folders_to_tags macro and start tagging at root folder #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix: add parent tags to folders_to_tags macro and start tagging at root folder #940

merged 2 commits into from
Jun 4, 2025

Conversation

rsazra
Copy link
Contributor

@rsazra rsazra commented May 27, 2025 •
edited
Loading

Summary

2 main things are changed for the folders_to_tags macro.

  1. Tagging starts with folders in the root of the TagStudio directory (i.e. on the same level as .TagStudio).
  2. Parent tags are assigned.

Tested on my library of ~850 images, nested up to 3 layers of folders deep.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@rsazra rsazra changed the title fix: add parent tags to folders to tags macro and start at root fix: add parent tags to folders_to_tags macro and start tagging at root folder May 27, 2025
@Computerdores Computerdores added Type: Bug Something isn't working as intended Status: Review Needed A review of this is needed labels May 27, 2025
@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development May 27, 2025
Computerdores
Computerdores approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on x86_64 Windows 10. Code looks good too (that is to say your changes look to be fine, while that part of the code base desperately needs a refactor)

@Computerdores Computerdores added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed Status: Mergeable The code is ready to be merged labels May 27, 2025
@CyanVoxel CyanVoxel added the TagStudio: Library Relating to the TagStudio library system label Jun 4, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development Jun 4, 2025
@CyanVoxel CyanVoxel merged commit e4bb07e into TagStudioDev:main Jun 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jun 4, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Computerdores Computerdores Computerdores approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended

Projects

TagStudio Development
Status: ✅ Done

Milestone

Alpha v9.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@rsazra @Computerdores @CyanVoxel