Skip to content

[BUGFIX] Use the return value of the UPDATE statement correctly in the LastSearchesRepository::update method #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RZivaralam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Use the return value of the UPDATE statement correctly in the LastSearchesRepository::update method #4501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/Domain/Search/LastSearches/LastSearchesRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
->set('keywords', $lastSearchesRow['keywords'])
->executeStatement();

if ($affectedRows < 1) {
if ($affectedRows === false) {

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13 on PHP 8.2 

Strict comparison using === between int and false will always evaluate to false.

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13 on PHP 8.4 

Strict comparison using === between int and false will always evaluate to false.

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13.4.x-dev on PHP 8.2 

Strict comparison using === between int and false will always evaluate to false.

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13.4.x-dev on PHP 8.4 

Strict comparison using === between int and false will always evaluate to false.

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13 on PHP 8.3 

Strict comparison using === between int and false will always evaluate to false.

Check failure on line 142 in Classes/Domain/Search/LastSearches/LastSearchesRepository.php

View workflow job for this annotation

GitHub Actions / TYPO3 13.4.x-dev on PHP 8.3 

Strict comparison using === between int and false will always evaluate to false.
throw new InvalidArgumentException(vsprintf('By trying to update last searches row with values "%s" nothing was updated, make sure the given "sequence_id" exists in database.', [json_encode($lastSearchesRow)]), 1502717923);
}
}
Expand Down
Loading