[BUGFIX] Use the return value of the UPDATE statement correctly in the LastSearchesRepository::update method
#4501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
changed the title
LastSearchesRepository::update method
…e `LastSearchesRepository::update` method executeStatement() returns: * false → SQL execution failed (real error) * 0 → UPDATE executed successfully, but no data changed * 1+ → UPDATE executed and changed data Fixes: TYPO3-Solr#4499
Collaborator
|
Are you sure about that statement?: 
There is no boolean return value on TYPO3 12 and 13 LTS Stacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reproduce
This confirms that the exception is triggered in valid and expected situations, for example when:
multiple users perform the same search query at nearly the same time, or
the same search term is executed repeatedly within the same second.
In these cases:
the UPDATE statement does find the row (correct sequence_id)
but writes identical values (keywords and second-based tstamp)
MySQL / MariaDB correctly returns affectedRows = 0
the current logic incorrectly interprets this as “row not found”