forked from OCA/account-analytic
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][CL] La cantidad debe ser positiva en apunte analítico #30
Open
CILC98
wants to merge
1
commit into
16.0
Choose a base branch
from
2024-08-CL-CantidadPositivaApunteAnalitico
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# -*- coding: utf-8 -*- | ||
# Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
|
||
from openupgradelib import openupgrade | ||
|
||
@openupgrade.migrate(use_env=True) | ||
def migrate(env, version): | ||
""" | ||
A todos los registros en la tabla account_analytic_line que tengan un valor negativo en el campo unit_amount | ||
lo convierte a positivo mediante SQL para no desencadenar algún método | ||
""" | ||
env.cr.execute(""" | ||
UPDATE account_analytic_line | ||
SET unit_amount = ABS(unit_amount) | ||
WHERE unit_amount < 0 | ||
""") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# -*- coding: utf-8 -*- | ||
# Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
|
||
from odoo import api, fields, models, _ | ||
|
||
|
||
class AccountAnalyticLine(models.Model): | ||
_inherit = 'account.analytic.line' | ||
|
||
# CRUD METHODS | ||
@api.model_create_multi | ||
def create(self, vals): | ||
""" | ||
Antes de crear, se verifica que el campo de cantidad sea positivo | ||
Si no lo es, se lo convierte a positivo | ||
""" | ||
for val in vals: | ||
if 'unit_amount' in val: | ||
if val['unit_amount'] < 0: | ||
val['unit_amount'] = abs(val['unit_amount']) | ||
return super().create(vals) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seguro no hay como desde los métodos que hereda el stock_move @CILC98??? Está muy agresivo desde el create...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existe tal vez algún caso en que los apuntes analíticos deban tener la cantidad en negativo? Si no es así, creo que sería la mejor opción, ya que no solo desde un lugar se crean estos apuntes.