[FIX][CL] La cantidad debe ser positiva en apunte analítico #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevTresCloud
requested changes
Aug 29, 2024
Comment on lines
+11
to
+21
| @api.model_create_multi | ||
| def create(self, vals): | ||
| """ | ||
| Antes de crear, se verifica que el campo de cantidad sea positivo | ||
| Si no lo es, se lo convierte a positivo | ||
| """ | ||
| for val in vals: | ||
| if 'unit_amount' in val: | ||
| if val['unit_amount'] < 0: | ||
| val['unit_amount'] = abs(val['unit_amount']) | ||
| return super().create(vals) |
There was a problem hiding this comment.
Seguro no hay como desde los métodos que hereda el stock_move @CILC98??? Está muy agresivo desde el create...
There was a problem hiding this comment.
Existe tal vez algún caso en que los apuntes analíticos deban tener la cantidad en negativo? Si no es así, creo que sería la mejor opción, ya que no solo desde un lugar se crean estos apuntes.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.